Adds support for allowing overrides to liveness, readiness, and startup probes #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up probes Preserves backward compatibility with existing consumers of Neo4J helm chart Tested by performing dry run of helm chart on main branch vs this feature branch and performing diff of manifests to ensure defaulted values causes manifests to render same values. Main branch: helm template ./neo4j --debug --dry-run --set neo4j.name=test-neo4j-cluster --set volumes.data.mode=defaultStorageClass > neo4j-cluster-manifests-main-branch.yaml Feature branch: helm template ./neo4j --debug --dry-run --set neo4j.name=test-neo4j-cluster --set volumes.data.mode=defaultStorageClass > neo4j-cluster-manifests-with-updates.yaml Then diffed the files.
jchavez443
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for allowing overrides to liveness, readiness, and startup probes
Preserves backward compatibility with existing consumers of Neo4J helm chart
Tested by performing dry run of helm chart on main branch vs this feature branch and performing diff of manifests to ensure defaulted values causes manifests to render same values.
Main branch:
helm template ./neo4j --debug --dry-run --set neo4j.name=test-neo4j-cluster --set volumes.data.mode=defaultStorageClass > neo4j-cluster-manifests-main-branch.yaml
Feature branch:
helm template ./neo4j --debug --dry-run --set neo4j.name=test-neo4j-cluster --set volumes.data.mode=defaultStorageClass > neo4j-cluster-manifests-with-updates.yaml
Then diffed the files.
Related Issue: #337