Make use of new database setting for determining conf directory #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelBergstrand
force-pushed
the
2025.01-make-use-of-conf-dir-setting
branch
from
74a0ae5 to
4856577
Compare
JoelBergstrand
commented
Jan 8, 2025
gem-neo4j
reviewed
Jan 10, 2025
| } | ||
| return neo4jConfFolder; | ||
| } | ||
| return neo4jConfig.get(configuration_directory).toString(); |
There was a problem hiding this comment.
I can't comment directly on the correct line, but where this is used now has an incorrect comment, can you fix that up? :) also the log info is wrong now
There was a problem hiding this comment.
Could the log say something like this?
Suggested change
| return neo4jConfig.get(configuration_directory).toString(); | |
| String neo4jConfFolder = neo4jConfig.get(configuration_directory).toString(); | |
| log.info("from database setting: server.directories.configuration=%s", neo4jConfFolder); | |
| return neo4jConfFolder; |
There was a problem hiding this comment.
Hmm actually, that line is about setting a system property. Do we even need that?
There was a problem hiding this comment.
I don't think we need the loging any more. Omitting it and updating the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of the new setting introduced in PR. This allows for the removal of the previously hacky way of determining the conf directory. Removes associated tests and updates tests that previously depended on the hack.