Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GraphAware TX API + Shell command for index import #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jazzido
Copy link
Contributor

@jazzido jazzido commented May 25, 2015

Hey @jexp,

There's two major changes in this PR:

  • I'm now using @graphaware framework for implementing the transaction change listener.
  • Initial version of a shell command for importing nodes into an ElasticSearch index ((Re)indexing tool #7)

Cheers,

M

@jexp
Copy link
Member

jexp commented May 26, 2015

I'd rather not pull in an external dependency at this point, as I think this should stay a minimal demonstration on how to achieve this kind of integration.

But if you think this makes sense, I'm more than happy to link your fork from the developer pages too as one example how to take this further.

What do you think?

@jazzido
Copy link
Contributor Author

jazzido commented May 26, 2015

Sure. I'm willing to maintain my fork, as I'm using this in production and not merely as a demonstration.
I also tried to avoid introducing a new dependency, but @graphaware's improved transaction classes allowed me to track node changes in the transaction handler without writing a lot of new (and potentially buggy) logic.

I'd appreciate if you could link to my fork from the README.

Thanks!

@jazzido jazzido mentioned this pull request Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants