[Add] Neo Build Error Base - Part 2

[cschuchardt88]

Blocks

• [Add] File Not Found Exception - Part 3 #3734
• [Add] File Denied Exception - Part 3 #3733
• [Add] Path Not Found Exception - Part 3 #3746
• [Add] Invalid File Format exception - Part 3 #3750

Change Log

• Added NeoBuildException.cs file.
• Added INeoBuildException.cs file.

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[shargon]

abstract class : Exception ?

[cschuchardt88]

No, this CAN BE used the same way as Exception class. My initial R&D did what your requesting. It didnt turn out very good after a while. Because we no longer using dotnet known exceptions. Plus that is why I added an interface.

You only use abstract class if you are defining common processing of data, not defining it.

Interface == define data
abstract == define code redundancy

[shargon]

Then better to rename it to INeoBuildError because it's not an exception @cschuchardt88

[cschuchardt88]

It is an exception. You use throw to throw the exception.

[shargon]

You can't throw an interface, so it's not an exception

[cschuchardt88]

No, The interface is to be used to let us know that the exception is ours. It we throw base exception and do if (something is exception e) we wouldn't know if its neo-build caught exception or code bug. Helps with other stuff too. You will see soon, what I'm talking about. If it ends up not being useful, than it will be removed. I'm just putting this stuff in the repo and doing a couple of files to, so the team can help develop, if they wish and making the review process easier then 100+ files at once. This is why I created neo-build branch. Nothing is set in stone.