Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SnapshotCacheReadOnly for read only snapshots #3729

Closed
wants to merge 3 commits into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Feb 9, 2025

Description

Avoid reusing the same class for different purposes.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Current

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88
Copy link
Member

cschuchardt88 commented Feb 9, 2025

Evite reutilizar la misma clase para diferentes propósitos.

I think you mean Avoid reusing the same class for different purposes.

@Jim8y
Copy link
Contributor

Jim8y commented Feb 9, 2025

LMAO, we have too many of these, please in the future try to make them reusable when we have time.

Copy link
Member

@cschuchardt88 cschuchardt88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you expand other interfaces? We are not going to have 50 classes for caching now are we? This is already out of hand. But now its getting worse.

@shargon
Copy link
Member Author

shargon commented Feb 10, 2025

I will do a different thing

@shargon shargon closed this Feb 10, 2025
@shargon shargon deleted the Split-Snapshot-and-readOnly branch February 10, 2025 10:33
@nan01ab
Copy link
Contributor

nan01ab commented Feb 10, 2025

Why not IReadOnlyStoreView?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants