Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] Neo Build Project Files #3727

Open
wants to merge 4 commits into
base: neo-build
Choose a base branch
from

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Feb 8, 2025

Description

Initialize Neo.Build.Core and Neo.Build.Core.Tests Projects. So, we can get started with building.

Just making it easier for PR review.

Blocks

Change Log

  • Added ./src/Shared/Neo.Build.Core/Neo.Build.Core.csproj file.
  • Added ./src/Shared/Directory.Build.props file.
  • Added ./tests/Neo.Build.Core.Tests/Neo.Build.Core.Tests.csproj file
  • Added solution directory shared
  • Added project Neo.Build.Core.Tests to solution directory ./shared/tests/.
  • Added project Neo.Build.Core to solution directory ./shared/.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • N/a

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 added the Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. label Feb 9, 2025
@cschuchardt88 cschuchardt88 self-assigned this Feb 9, 2025

<IsPackable>true</IsPackable>
<PackageId>$(RootNamespace)</PackageId>
<PackageIcon>neo.png</PackageIcon>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is relative to Shared folder or where?

Copy link
Member Author

@cschuchardt88 cschuchardt88 Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared is where this file is placed with in src directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. Neo Build Waiting for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants