Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Project File Normalization #3715

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Feb 5, 2025

Change Log

  • Move common msbuild properties to Directory.Build.props.
  • Fixed pathing when solution file isn't targeted for builds.
  • Add new nuget source (./pkgs/ directory in the root).
  • Added `./pkgs/' directory in the root.
  • Added PackageOutputPath property for msbuild in Directory.Build.props files.
  • Added *.target files to .gitattributes file.
  • Added *.snupkg files to .gitignore file.
  • Removed common properties for OutputPath, PackageId and RootNamespace from *.csproj files.
  • Updated github workflow file (nuget.yml) to use ./pkgs/ directory in the root.
  • Updated copyright year to 2025.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

src/Neo.CLI/Neo.CLI.csproj Outdated Show resolved Hide resolved
.github/workflows/nuget.yml Show resolved Hide resolved
src/Directory.Build.props Show resolved Hide resolved
<PackageIcon>neo.png</PackageIcon>
<PackageOutputPath>../../pkgs/</PackageOutputPath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well,, the output path is changed again.... the name is weird cause neogo has this folder as well for another purpose.

Copy link
Member Author

@cschuchardt88 cschuchardt88 Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This for building nuget packages. What would you like the name to be? Other than that everything else is the same. Just moved to the *.props files.

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Feb 7, 2025

@shargon @Jim8y @nan01ab
You all need to download the PR's code in any PR, when you think there is an issue. Prove the issue is real, than create issue in the given PR's about it. I spend a lot of time testing and critiquing the code with a fine tooth comb. It really wastes my time and everyone else. Having to example something, if you would just download the PR and test it. If downloading the PR is a waste of time or to much for you. Now you know how I feel explaining it. Now asking a question about if something changed or what does it do. Is a good question. Also I go out of my way to fill out a detailed description. So All I ask is take some time to read the description and download PR if you think something doesn't work the way you think. Especially if the code is too complex for you to understand. Just do the research before you start issue please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants