Refactor await native #917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
commented
Feb 20, 2024
Comment on lines
+154
to
+174
| /* | ||
| if (result is not ContractTask task) | ||
| throw new Exception($"Error casting {native.Name}.{method.Name} to ContractTask"); | ||
|
|
||
| task.GetAwaiter().GetResult(); | ||
| */ | ||
|
|
||
| if (result is null) | ||
| throw new Exception($"{native.Name}.{method.Name} result can't be null"); | ||
|
|
||
| method = result.GetType().GetMethod("GetAwaiter", BindingFlags.Public | BindingFlags.Instance)!; | ||
| result = method?.Invoke(result, Array.Empty<object>()); | ||
|
|
||
| if (result is null) | ||
| throw new Exception($"{native.Name}.{method?.Name}.GetAwaiter() result can't be null"); | ||
|
|
||
| method = result.GetType().GetMethod("GetResult", BindingFlags.Public | BindingFlags.Instance)!; | ||
| result = method?.Invoke(result, Array.Empty<object>()); | ||
|
|
||
| if (result is not null) | ||
| throw new Exception($"{native.Name}.{method?.Name}.GetAwaiter().GetResult() can't be not null"); |
There was a problem hiding this comment.
@Jim8y I know that is not a fix, but while we found the solution I think this will allow me to continue working
|
Not required, package was fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some problems with the netstandard change and the current package, trying to find how to solve it