dumpnef performance #1201
Merged
dumpnef performance #1201
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Oct 9, 2024
| } | ||
| } | ||
| } | ||
| if (a < script.Length) | ||
| dumpnef += $"{WriteInstruction(a, script.GetInstruction(a), script.GetInstructionAddressPadding(), nef.Tokens)}\n"; | ||
| dumpnef.Append($"{WriteInstruction(a, script.GetInstruction(a), addressPadding, nef.Tokens)}\n"); |
There was a problem hiding this comment.
Use AppendLine and remove the \n?
There was a problem hiding this comment.
OK. WILCO in 24 hours
shargon
approved these changes
Oct 10, 2024
|
what is the performance improvement |
Jim8y
approved these changes
Oct 10, 2024
string addressPadding enumerates instructions only once instead of many times |
I mean what is the perforamcne after this pr. |
< 1 second. Negligible time compared to compilation. |
stringbuilder it's much faster than string concat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent almost 1 minute in dumpnef for a huge contract reaching instruction address of 22000. So I profiled dumpnef and made some optimizations...