fix: string.Trim only trim ' '

[nan01ab]

fix of #1186

string.Trim uses same semantics with char.IsWhiteSpace to determine an ASCII char that is whitespace or not.

[nan01ab]

@Jim8y

[Jim8y]

need unit.test as well

[shargon]

UT required

[vncoelho]

I believe the change is correct following the logic here, but in fact a UT is necessary

[nan01ab]

UT will be added later.

[Jim8y]

UT will be added later.

Wait, i am working on fixing the method itself, your UT will not work before that.

[Jim8y]

@shargon @vncoelho @nan01ab please check the latest update and unit test.

[shargon]

I don't like inline methods here, but if it works for you @Jim8y, I'm not against to

[Jim8y]

I don't like inline methods here, but it works for you @Jim8y, I'm not against to

@shargon Thank you for your support. I know what you mean clearly, and i actually also don't like it, but doing it this way makes it eaiser to implement the method and easier to review the code.

Implement these methods purely in opcode is very hard to maintain and review (easy to be wrong, and hard to find them). I am thinking that maybe when we have multiple these unly implementations, we can group them and make these methods into something like suger syntax.

We can figure out a better way later.