cancel unnecessary constructors #1185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to cancel-constructor # Conflicts: # tests/Neo.SmartContract.Framework.UnitTests/TestingArtifacts/Contract_Attribute.cs # tests/Neo.SmartContract.Framework.UnitTests/TestingArtifacts/Contract_ManifestAttribute.cs # tests/Neo.SmartContract.Framework.UnitTests/TestingArtifacts/Contract_SupportedStandard26.cs # tests/Neo.SmartContract.Framework.UnitTests/TestingArtifacts/Contract_SupportedStandard27.cs
Jim8y
approved these changes
Oct 2, 2024
shargon
reviewed
Oct 2, 2024
| @@ -34,7 +34,7 @@ public class CompilationEngine(CompilationOptions options) | |||
| internal CompilationOptions Options { get; private set; } = options; | |||
| private static readonly MetadataReference[] CommonReferences; | |||
| private static readonly Dictionary<string, MetadataReference> MetaReferences = []; | |||
| private static readonly Regex s_pattern = new(@"^(Neo\.SmartContract\.Framework\.SmartContract|SmartContract\.Framework\.SmartContract|Framework\.SmartContract|SmartContract)$"); | |||
| internal static readonly Regex s_pattern = new(@"^(Neo\.SmartContract\.Framework\.SmartContract|SmartContract\.Framework\.SmartContract|Framework\.SmartContract|SmartContract|Neo\.SmartContract\.Framework\.Nep17Token|Neo\.SmartContract\.Framework\.TokenContract|Neo.SmartContract.Framework.Nep11Token<.*>)$"); | |||
There was a problem hiding this comment.
Maybe we should try to remove this regex
There was a problem hiding this comment.
@Hecate2 this is needed? it should check the hierarchy
There was a problem hiding this comment.
static bool IsDerivedFromSmartContract(INamedTypeSymbol classSymbol, Regex pattern)
{
var baseType = classSymbol.BaseType;
while (baseType != null)
{
if (pattern.IsMatch(baseType.ToString() ?? string.Empty))
{
return true;
}
baseType = baseType.BaseType;
}
return false;
}
There was a problem hiding this comment.
IsDerivedFromSmartContract returns true even when a asmart contract is derived for many times. e.g.
class A: SmartContract
class B: A
class C: B
IsDerivedFromSmartContract returns true for B and C. But in B and C we may call base, or utilize the constructor of A.
shargon
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO in the future: regex may not be reliable enough