Add dtype to SemanticPointer and fix repr #245
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
This is an experimental feature request (split off from #243 and rebased onto master), that allows one to experiment with other data types for semantic pointers, such as
np.complex64
.Full support is not provided. The intended scope is for offline algebraic manipulation of SPs. In the future, one might wish to support complex types in the neural implementations as well.
Interactions with other PRs:
Assuming #243 is merged first, then this would need to be rebased such that
dtype
also passed into the new methods for SP fractional binding. Also changes may be needed to allowfractional_bind
to return a complex SP if the datatype is complex.How has this been tested?
Unit tests pass, but new unit tests are needed (see 'Still to do').
How long should this take to review?
Types of changes:
Checklist:
Still to do:
vocabulary.py
)