Better stopping behaviour for snips #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now send an explicit stop signal, and once that is received the snip will just return immediately.
They should not be inside the with; data may not be transferred off the board until the context manager exits.
Closed
tbekolay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now send an explicit stop signal, and once that is received the snip will just return immediately.
We needed better stopping behaviour for working with nengo_gui (since we don't know when the simulator might be closed). It also handles pressing Ctrl-C while your model is running, which might be handy.
[EDIT:] This PR may need to be re-thought in terms of making it fit with #26 , which made some big changes to the communication protocol between chip and host.