Add test for input synapses #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbekolay
force-pushed
the
input-syn-test
branch
from
2f32436
to
8196aad
Compare
drasmuss
force-pushed
the
input-syn-test
branch
from
8196aad
to
ff2b605
Compare
drasmuss
force-pushed
the
input-syn-test
branch
from
1f603d9
to
36220a2
Compare
arvoelke
reviewed
Oct 24, 2019
| plt.plot(t, sim_filt, label="nengo_loihi") | ||
| plt.legend(loc="best") | ||
| plt.twinx() | ||
| plt.plot(t, sim.data[p_stim], c="k") |
There was a problem hiding this comment.
Do you have this plot handy to upload here? Could be useful in the future to know what you mean about the weird effects at the end.
There was a problem hiding this comment.
I don't, but the weird effects are basically that Nengo Loihi's decoded value drops toward zero in the last 50 or so ms of the simulation, regardless of the length of the simulation. I didn't look into it much detail to know why.
tbekolay
commented
Oct 24, 2019
nengo_loihi/tests/test_conv.py
Outdated
| @@ -707,7 +707,9 @@ def test_conv_split(Simulator, rng, plt, allclose): | |||
|
|
|||
| @pytest.mark.skipif(nengo_transforms is None, reason="Requires new nengo.transforms") | |||
| def test_conv_preslice(Simulator, plt): | |||
| from nengo._vendor.npconv2d.conv2d import conv2d | |||
| from nengo._vendor.npconv2d.conv2d import ( # pylint: disable=import-outside-toplevel | |||
There was a problem hiding this comment.
I would just turn these into a pytest.importorskip, then remove the skipif
drasmuss
force-pushed
the
input-syn-test
branch
from
af226b7
to
2abff99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the test described in #63, with some additional filtering (Nengo Loihi drifts a little bit over time) and with an assertion at the end.
It's based on #247, which should be merged first.
As this just adds a test, I don't believe it needs a changelog entry.