Don't include setup.py hash in cache key #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having separate caches for different versions of setup.py increases the github storage usage, and is unlikely to provide much practical benefit.
tbekolay
approved these changes
Jan 15, 2024
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)nengo_bones/version.py
|
drasmuss
force-pushed
the
no-cache-hash
branch
2 times, most recently
from
c2c762f
to
7d0dafb
Compare
drasmuss
force-pushed
the
no-cache-hash
branch
from
d357318
to
fdfa417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having separate caches for different versions of setup.py increases the github storage usage, and is unlikely to provide much practical benefit.