Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_shifts return value more useful; add test for shifts #317

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

ethanbb
Copy link
Collaborator

@ethanbb ethanbb commented Sep 8, 2024

Fixes #310. This is an API change for mcorr.get_shifts(). Changes in this PR:

  • Don't return the first output of get_shifts anymore, since it was confusing/seemingly not very useful
  • For piecewise case, return an n_dims-length list of n_frames x n_patches matrices rather than an n_dims*n_patches-length list of n_frames-length vectors.
  • Remove the default value for pw_rigid, since it seemed too easy to forget to pass this and get an incorrect output as a result (came up when I was running the new test)
  • Test the shifts against ground truth (currently only tests the piecewise case). I made a new zenodo upload with a shifts ground truth file. Note that this is based off of the upload for Don't filter out NaNs for contours #309, so since that's not merged yet, the contour ground-truth tests will fail.

@ethanbb ethanbb merged commit 5d7c9b3 into nel-lab:master Sep 9, 2024
0 of 5 checks passed
@ethanbb ethanbb deleted the get-shifts-update branch September 9, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of shifts for pw_rigid motion correction is difficult to interpret
2 participants