Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Simplify reloadLocalizations method and add comments in regexp #32

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

marchv
Copy link

@marchv marchv commented May 11, 2014

Hi :)

I have started to look into how to support comments, which also can be edited from the plug-in. But my first iteration was a simplification of the regular expression handling, which I hope you like.

Thanks and best regards! :)

@marchv
Copy link
Author

marchv commented May 11, 2014

This simplification seems also to fix the problem with comments mentioned by others :)

@marchv
Copy link
Author

marchv commented May 21, 2014

Hello :)
I have completed my support for comments now. If this could be adopted then the plugin would fit nicely together with the output of genstrings and also Transifex's comments. The last commit however is special but it tries to solve the problem where multiple string-files with same name and same language are found.

Cheers!

…ssible duplicate name-language combos"

This reverts commit 9f88ae7.
…guish possible duplicate name-language combos""

This reverts commit b063b5d.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant