Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug #446: buffered reader is default for jsonl #482

Merged
merged 27 commits into from
Jan 20, 2025
Merged

Bug #446: buffered reader is default for jsonl #482

merged 27 commits into from
Jan 20, 2025

Conversation

neilotoole
Copy link
Owner

  • See Buffered reader is default for jsonl #446.
  • Adds a config option (tuning.scan-buffer-limit) to set the buffer size of bufio.Scanner.
  • Refactored scanner/line-related functionality from pkg stringz to its own scannerz pkg.
  • Add a new option type datasize.Opt that knows how to interpret 64KB, 8MB, etc.
  • Move Go template functionality from stringz to its own templatez pkg.

@neilotoole neilotoole linked an issue Jan 19, 2025 that may be closed by this pull request
Buffered reader is default for jsonl #446
Closed
@neilotoole neilotoole marked this pull request as ready for review January 20, 2025 00:31
@neilotoole neilotoole merged commit 01abfb6 into master Jan 20, 2025
12 checks passed
@neilotoole neilotoole deleted the 446-buffered-reader-is-default-for-jsonl branch January 20, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buffered reader is default for jsonl
1 participant
@neilotoole