Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes https://github.com/NBISweden/LocalEGA-SE-Deployment/issues/525.
Description
How to test
starter-kit-storage-and-interfaces
, branchfeature/auth-add-userinfo-to-db
together withstarter-kit-lsaai-mock
, as described in the Readme.docker exec -it postgres psql postgresql://postgres:rootpass@postgres/sda -At -c "select * from sda.userinfo"
Extra info
I will be away next week, so I put the code here, in case someone wants to take care of it. It's working when tested manually with lsaai-mock, but there are no integration tests and also no unit tests for auth. Adding integration tests is not very straight forward, though, so it might be out of scope for this issue.
Also the chart tests fail, but that might be unrelated to this PR.