Docs/general update nov2023 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
force-pushed
the
docs/general-update-nov2023
branch
3 times, most recently
from
f6f85b0 to
198d882
Compare
blankdots
force-pushed
the
docs/general-update-nov2023
branch
2 times, most recently
from
79bad3b to
7cbfe18
Compare
kjellp
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
LGTM overall. Was a bit unsure about the "sensitive-data-archive/tree/main/" paths? And the use of tags to separate/run different microsevices from the same overall image (thought there will be a few different images, and a specific cmd/servicename to be provided in combination with the right image).
not sure how else to reference those, but we can fix in the next iteration
we can bring that up in our bi-weekly, however that is something already existing and i just used that |
jbygdell
requested changes
Nov 14, 2023
jbygdell
approved these changes
Nov 14, 2023
aaperis
approved these changes
Nov 15, 2023
- sort ascending - remove duplicates - everything lowercase
Co-authored-by: Joakim Bygdell <[email protected]>
Co-authored-by: Joakim Bygdell <[email protected]>
Co-authored-by: Alex Aperis <[email protected]>
blankdots
force-pushed
the
docs/general-update-nov2023
branch
from
1218d0f to
dfb3354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Changes made:
sda-*repositories