Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API documentation #146

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Add API documentation #146

merged 2 commits into from
Dec 19, 2024

Conversation

viklund
Copy link
Member

@viklund viklund commented Dec 19, 2024

Related issue(s) and PR(s)
This PR closes [issue number].

Description

How to test

Copy link
Contributor

@aaperis aaperis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but it would be nice if some text and reference to the api was included in the docs as well, e.g. here

@viklund
Copy link
Member Author

viklund commented Dec 19, 2024

Looks ok, but it would be nice if some text and reference to the api was included in the docs as well, e.g. here

Good point. I will add that.

@viklund viklund requested review from aaperis and a team December 19, 2024 12:59
Copy link

@kostas-kou kostas-kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only thing here is that rbac as it is now is incomplete. There will be an issue soon about this bug

@viklund viklund merged commit 73979b7 into master Dec 19, 2024
3 checks passed
@viklund viklund deleted the feature/api-docs branch December 19, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants