Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic tox with pyenv setup for testing #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

assarbad
Copy link
Contributor

  • Amended ignore file
  • Added tox.ini to test an array of Python versions
  • .python-version file (used by pyenv) to enable concurrent availability of Python installations

Hope you find this suitable. If not I won't take offense. But I wanted to be able to test across a number of Python versions beyond just 3.7 and 2.7.

- Amended ignore file
- Added tox.ini to test an array of Python versions
- .python-version file (used by pyenv) to enable concurrent availability
  of Python installations
@ned14
Copy link
Owner

ned14 commented Nov 14, 2022

Thanks for the PR. Doesn't tox also support windows?

@assarbad
Copy link
Contributor Author

Thanks for the PR. Doesn't tox also support windows?

It does, but before adding it, I want to get Linux straightened out. And when that all works, I can deal with Windows, I suppose. One item at a time, though. (And I can't even ever test macOS.)

@ned14
Copy link
Owner

ned14 commented Nov 16, 2022

Will you promise to me that if I merge this now that you will contribute tox support for windows?

@assarbad
Copy link
Contributor Author

Will you promise to me that if I merge this now that you will contribute tox support for windows?

Frankly. Nope. And the reason isn't because I am lazy or unwilling to do it (in fact chances are you will see this from me). But I am unable to commit this and give you a reasonable time frame (and by reasonable I mean anything I would deem reasonable for my own projects).

If you don't want to merge it, that's fine with me. I'll simply try to maintain a branch with this patch rebased on latest master from you (and another branch combining my own as-of-yet unmerged patches). This way I can make use of it and drive the effort of increasing test coverage all the while not committing to a fixed deadline, which would seem dishonest to you if I don't make the deadline all the while making me feel terrible for not having made it 😉

Git for Windows uses a similar approach to stay "afloat" with the Windows-specific patches against the upstream master branch.

@assarbad assarbad closed this Nov 16, 2022
@ned14
Copy link
Owner

ned14 commented Nov 18, 2022

Thanks for the honesty! I'm going to reopen this PR however, as roughly once per year I try to close all open bug count, merge all open PRs and do a release. If when that time comes this is still open I'll implement the windows support and merge it.

@ned14 ned14 reopened this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants