This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
Lua_helper.callback_handler: return nil if the haxe function returned null #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMMaster636
approved these changes
Oct 5, 2022
Luisinhi010
approved these changes
Dec 4, 2022
jbmagination
added a commit
to Funkin4RPlace/linc_luajit
that referenced
this pull request
May 20, 2023
Merge upstream PR nebulazorua#8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, if the haxe function return null, then the stack used here (which appear to be different than the one used to register it, as the documentation say this one is emptied after return), then it read the last input argument.
With this, it instead return nothing (which then default to nil).
I do this for the reason exposed here: ShadowMario/FNF-PsychEngine#10737 (comment)