解决同一点的Tag实体类相互独立时，映射的Object类型可能发生错误的问题 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CorvusYe
reviewed
Aug 21, 2024
Comment on lines
+89
to
+98
| : value.isDate() ? transformDate(value.asDate()) | ||
| : value.isDateTime() ? transformDateTime(value.asDateTime()) | ||
| : value.isVertex() ? transformNode(value.asNode(),resultType) | ||
| : value.isEdge() ? transformRelationship(value) | ||
| : value.isPath() ? value.asPath() | ||
| : value.isList() ? transformList(value.asList()) | ||
| : value.isSet() ? transformSet(value.asSet()) | ||
| : value.isMap() ? transformMap(value.asMap()) | ||
| : value.isDuration() ? transformDuration(value.asDuration()) | ||
| : null; |
There was a problem hiding this comment.
我也觉得这个格式看起来会更符合一些，但是代码风格校验会通不过
| MapperContext mapperContext = MapperProxy.ENV.getMapperContext(); | ||
| Map<String, Class<?>> tagTypeMapping = mapperContext.getTagTypeMapping(); | ||
| Class<?> nodeType = null; | ||
| Class<?> nodeType = resultType; |
There was a problem hiding this comment.
这边可能会导致 nodeType 始终都不为空，可能会影响到现有的 如果无映射类型会将节点转换成 map 的功能。虽然正常不推荐该用法
There was a problem hiding this comment.
如果只是找到 tagType 的时候 增加一个判断 resultType和tagType 是否具备继承关系，具备继承关系才赋予 nodeType 为tagType，这样应该可以不影响 转Map
| @@ -79,24 +79,26 @@ public class ResultSetUtil { | |||
| * @param <T> 目标结果类型 | |||
| * @return | |||
| */ | |||
| public static <T> T getValue(ValueWrapper value) { | |||
| public static <T> T getValue(ValueWrapper value,Class<T> resultType) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
关键代码如图，执行 transformNode 的时候传入 resultType ，当 tagType 是 nodeType 的 子类时 才去将 nodeType 换成 tagType
