Fix defaults for optionals, remove placeholder exhibits, do not add s…

…ection if empty (#19) * Allow `None` for optional items * Remove default values which were used for tests * Only
nebari-dev · Jun 13, 2024 · 2f59b08 · 2f59b08
1 parent f909204
commit 2f59b08
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 20 deletions.
diff --git a/jupyterlab_gallery/handlers.py b/jupyterlab_gallery/handlers.py
@@ -26,6 +26,7 @@ def get(self):
             json.dumps(
                 {
                     "title": self.gallery_manager.title,
+                    "exhibitsConfigured": len(self.gallery_manager.exhibits) != 0,
                     "apiVersion": "1.0",
                 }
             )

diff --git a/jupyterlab_gallery/manager.py b/jupyterlab_gallery/manager.py
@@ -31,36 +31,30 @@ def __init__(self, *args, **kwargs):
         Dict(
             per_key_traits={
                 "git": Unicode(help="Git URL used for cloning"),
-                "homepage": Unicode(help="User-facing URL to open if any"),
                 "title": Unicode(help="Name of the exhibit"),
-                "description": Unicode(help="Short description"),
+                "homepage": Unicode(
+                    help="User-facing URL to open if any", allow_none=True
+                ),
+                "description": Unicode(help="Short description", allow_none=True),
                 "token": Unicode(
-                    help="Personal access token - required if the repository is private"
+                    help="Personal access token - required if the repository is private",
+                    allow_none=True,
                 ),
                 "account": Unicode(
-                    help="Username or name of application - required if the repository is private"
+                    help="Username or name of application - required if the repository is private",
+                    allow_none=True,
                 ),
                 # TODO: validate path exists
-                "icon": Unicode(help="Path to an svg or png, or base64 encoded string"),
+                "icon": Unicode(
+                    help="Path to an svg or png, or base64 encoded string",
+                    allow_none=True,
+                ),
                 # other ideas: `path_in_repository`, `documentation_url`
             }
         ),
         config=True,
         allow_none=False,
-        default_value=[
-            {
-                "git": "https://github.com/nebari-dev/nebari.git",
-                "homepage": "https://github.com/nebari-dev/nebari/",
-                "title": "Nebari",
-                "description": "🪴 Nebari - your open source data science platform",
-            },
-            {
-                "git": "https://github.com/nebari-dev/nebari-docker-images.git",
-                "homepage": "https://github.com/nebari-dev/nebari-docker-images/",
-                "title": "Nebari docker images",
-                "description": "Nebari Docker images",
-            },
-        ],
+        default_value=[],
     )
 
     destination = Unicode(

diff --git a/src/index.ts b/src/index.ts
@@ -64,7 +64,7 @@ const plugin: JupyterFrontEndPlugin<void> = {
 
     const title = data.title === 'Gallery' ? trans.__('Gallery') : data.title;
     // add the widget to sidebar before waiting for server reply to reduce UI jitter
-    if (launcher && isNewLauncher(launcher)) {
+    if (launcher && isNewLauncher(launcher) && data.exhibitsConfigured) {
       launcher.addSection({
         title,
         className: 'jp-Launcher-openExample',

diff --git a/src/types.ts b/src/types.ts
@@ -1,6 +1,7 @@
 export interface IGalleryReply {
   title: string;
   apiVersion: string;
+  exhibitsConfigured: boolean;
 }
 
 export interface IExhibitReply {