Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase push notification priority #375

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

williamlines
Copy link
Contributor

@williamlines williamlines commented Aug 11, 2023

This increases the priority of the push notifications sent to the optic expo app to the maximum allowed, making the notification wake up locked devices and increasing the chance for a notification to be seen.

closes: nearform/optic-expo#1153

@williamlines
Copy link
Contributor Author

Tested on my android device, it wakes up when the screen is locked.

Copy link

@ollyjohn ollyjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a linked issue

@williamlines
Copy link
Contributor Author

Whoops, just added

@williamlines williamlines merged commit 83fc13b into master Aug 11, 2023
3 of 4 checks passed
@williamlines williamlines deleted the chore/increase-push-notification-priority branch August 11, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications appear to have low priority and be background only
2 participants