Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Come up with a standard to pass secrets to the deployed application #129

Closed
wants to merge 5 commits into from
Closed

feat: Come up with a standard to pass secrets to the deployed application #129

wants to merge 5 commits into from

Conversation

spchortis
Copy link
Contributor

  • Creates a K8s secret if not exists & updates the secret if already there
  • Secret name: application name + secret key
  • Creates Knative secret ref only if it is not already in place
  • Adding secret flag test case

@francardoso93
Copy link
Contributor

Closing as this is a duplicate of #144.

  • This PR doesn't support importing existing secrets into apps (solved by 3edf2ea)
  • Lack of visibility of existing secrets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spchortis @francardoso93