chore: Simplify developer experience, no need for curl -H just browse a url #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucaLanziani
reviewed
Oct 3, 2023
| @@ -133,6 +161,21 @@ func (c icli) InitCMD() *cli.Command { | |||
| Action: c.InitServiceAccountCMD, | |||
| Before: c.baseBeforeFunc, | |||
| }, | |||
| { | |||
| Name: "knative-domain", | |||
| Usage: "updates knative service default domain", | |||
There was a problem hiding this comment.
Can we make clear that a positional argument is required here?
PS. I've tried it with test.example.com and the config map now has both the domains, is this expected?
➜ initium-cli git:(chore/knative_domain) ✗ kubectl get cm config-domain -n knative-serving -o yaml
apiVersion: v1
data:
example.com: ""
test.example.com: ""There was a problem hiding this comment.
- I have added a condition to look for an argument and if not to error out with a msg.
- The behaviour is what I mentioned yesterday when you suggested that maybe tilt or argocd reverts to example.com. Will investigate..
LucaLanziani
reviewed
Oct 3, 2023
| func DomainUpd(kn_domain string, config *rest.Config) error { | ||
| // Default Knative values | ||
| configMapName := "config-domain" | ||
| namespace := "knative-serving" |
There was a problem hiding this comment.
We should not be hardcoding this imho, it limits the options in case someone has knative deployed in a different namespace.
Let me see if we can set the right default for the namespace flag
There was a problem hiding this comment.
checking if we can use namespace flag..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Simplify developer experience, no need for curl -H just browse a url one.