Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes: Work with a developer to refine the default docker file for node #106

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

spchortis
Copy link
Contributor

@spchortis spchortis commented Sep 13, 2023

Node dockerfile:

  • Use caching layers in case the same runner or local builds it
  • Rename workspace to avoid multiple src under the same path

@zaremba-tomasz
Copy link
Contributor

It would be nice to add a USER directive to avoid using root.

@spchortis
Copy link
Contributor Author

It would be nice to add a USER directive to avoid using root.

I had tried initially but since there is no shell in it would need few steps to create a non root user. Didn't do since these are dev related images.
After some digging I found that nonroot may exist in the image although it is not nonroot tagged image. I can try out.

@spchortis spchortis merged commit 563d572 into main Oct 3, 2023
1 check passed
@spchortis spchortis deleted the chore/refine_dockerf_node branch October 3, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants