feat: initium project type flag #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pehesi97
changed the title
|
The logic works as expected, we might improve the error message in the second case ➜ initium-cli git:(chore/issue-100) go run main.go init config
app-name: initium-cli
container-registry: ghcr.io/nearform
default-branch: main
dockerfile-name: null
env-var-file: .env.initium
image-pull-secrets: null
project-type: go
runtime-version: null
➜ initium-cli git:(chore/issue-100) touch package.json
➜ initium-cli git:(chore/issue-100) ✗ go run main.go init config
2023/10/19 10:23:33 FATA required flags "project-type" not set
exit status 1 |
src/services/project/project.go
Outdated
| var projectType ProjectType | ||
| var err error | ||
| if proj.Type != "" { | ||
| projectType, err = proj.matchType() |
There was a problem hiding this comment.
Can we use the IsValidProjectType here?
There was a problem hiding this comment.
Line 120 or 121?
Because the function only returns a bool that indicates whether the project type is valid or not
Co-authored-by: Luca Lanziani <[email protected]>
LucaLanziani
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100.
Testing
This should detect the project type and store it on the initium config file. From that moment on, any initium-cli command will work without the need of specifying the project type.
If the CLI doesn't detect the type, the command will fail and the project type will be a required flag / environment variable.