test: add tests for queries with fragment and alias #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisgrint
force-pushed
the
test/11-add-tests-for-fragment-and-alias
branch
3 times, most recently
from
c03fc12
to
a393d3d
Compare
|
Hi @simone-sanfratello any thoughts on whether we need to support aliasing on the fields? Thanks |
|
If they are not supported out-of-the-box, it's not trivial to implement What I'd do is to check on the gateway the "stuff" is been sent and send the required info, then here forward or handle again |
krisgrint
force-pushed
the
test/11-add-tests-for-fragment-and-alias
branch
from
a393d3d
to
9789987
Compare
krisgrint
force-pushed
the
test/11-add-tests-for-fragment-and-alias
branch
from
9789987
to
69e948f
Compare
simoneb
approved these changes
May 31, 2022
Closed
This was referenced May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
This PR adds tests which check if queries with fragments or aliases are forwarded correctly to the target service from the created federated service.
Queries with fragments work as expected.
Aliasing the query works as expected, as does aliasing results when using the same query more than once.
Aliasing fields in response to the query is not supported out of the box - a new issue has been created to track implementation of this #26
Also renames test/build-federated-info.test.js so that it is picked up by the test runner