feat!: Upgrade to Fastify 5 and Node 20 #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simoneb Here is the follow up to yesterdays Fastify 5.x upgrade on |
|
Thanks @markrzen for the PR. CI is broken presumably because it needs some secrets to be set during execution, which are not available in forks for security reasons. Are you comfortable that if we merge this, CI will be green in master? |
|
@simoneb All the other tests run successfully. That's about as confident as I can get. We could change the base to be a branch on your origin, then merge it there, so CI runs? |
|
Nah I'm good with merging to master, if anything breaks we can still follow up |
simoneb
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
Resolves: #366