Downgrade eslint v8 to v7.32 because of compatibility issues #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is the build green if eslint does not work? |
|
Good question. Build is indeed green but when trying to run the |
|
See #179. It is now failing as I would expect, and the problem was in the build process which was caching dependencies. Can you close this PR and make this change in that branch? Once that PR is green, we're good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eslint-config-standardis not yet compatible witheslintversion 8, see standard/eslint-config-standard#192. Since this is blocking the release I've decided to downgradeeslintto version 7.32.0 until the issue gets resolved.