Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring boilerplate Wallet class in core library #1276

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

denbite
Copy link

@denbite denbite commented Jan 8, 2025

@gagdiez
Copy link

gagdiez commented Jan 8, 2025

While I like the idea of bringing all the commonly used interface, I think it would be nicer if we could get it directly implemented in the Wallet, so people does not need to create a new object to use these methods

By implementing it in the wallets we should be able to also use the provider that the user configured on the selector, instead to instantiate a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: NEW❗
Development

Successfully merging this pull request may close these issues.

2 participants