Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for meteor wallet mobile app #1275

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

Elabar
Copy link
Contributor

@Elabar Elabar commented Jan 2, 2025

Description

Meteor Wallet App integration. We mainly use this for in app browser, where user can browse the dapp within the meteor wallet. We are using instant-link wallet type to automatically sign in user for the dapp they are browsing.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Collaborator

@trechriron trechriron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial read is two thumbs up. Would like another wallet builder to take a look. I would really like to avoid one pair of eyes on a review. Wallet Selector is too important to all of us. :-)

- also added a ping in signIn that should resolve almost immediately to avoid auto login stuck
- this is so our app make sure we are processing the right message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants