Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitelisted senders have unlimited allowance and proper checks for ft_transfer to burn address #41

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

anthony-near
Copy link
Collaborator

@anthony-near anthony-near commented Oct 31, 2023

@anthony-near anthony-near self-assigned this Oct 31, 2023
@anthony-near anthony-near changed the title proper checks for ft_transfer to burn address whitelisted senders have unlimited allowance and proper checks for ft_transfer to burn address Oct 31, 2023
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
Copy link
Contributor

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to predict if it works without integration tests TBH.
The fact that we are mixing concepts of senders and receivers is questionable.

src/main.rs Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
@volovyks
Copy link
Contributor

volovyks commented Nov 2, 2023

@anthony-near once the docker image is updated, we can test this functionality by rerunning tests here: near/mpc#347
For all of them to pass we will need to deploy it to dev env.

@anthony-near
Copy link
Collaborator Author

anthony-near commented Nov 2, 2023

It's hard to predict if it works without integration tests TBH.

I know it's not as good as an integration test, but I ran it locally and called the /get_allowance endpoint after server startup (the "unlimited" allowance is initialized before the app routes are created) and it worked as expected.

@anthony-near anthony-near merged commit e51e173 into main Nov 2, 2023
1 check passed
@anthony-near anthony-near deleted the feature/custom_deserialization branch February 28, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants