fix(state-sync): set the sync hash only when it's final #12720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to find the sync hash, and with an epoch length of 6 temporary_account_during_resharding() fails in check_txs() because account0 has not synced the parent shard by the resharding block yet
|
There are a couple more test failures that happen because clients are dropping transactions because epoch lengths are too short and they're not caught up by the time the transaction comes in, and so they drop it. Will fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a bug that can happen if the sync hash that we set doesn't end up on the canonical chain. Here we add a couple more test cases for that, and fix it by considering only finalized blocks when we set the state sync hash, and changing the snapshot logic to check whether the current head is the prev block of what will be the sync hash block. This means the sync hash is found a little later than it was before, but on a chain with long epoch lengths, it shouldn't be a problem.