refactor: move serialisation out of ValidatorSigner #12422
+14
−86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we add a method to
ValidatorSigner
for every data type we want to sign. I'm not sure what exactly is a benefit of doing that, but such approach results in quite a few annoying issues:verify
method on public key passing signature and bytes, why should signing be any different?ValidatorSigner
public API making it awkward to work with.This PR repurposes
sign_chunk_contract_accesses
to be a genericsign_bytes
method and replaces usage for witness contract code distribution related types. The rest will be addressed in a separate PR.