Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove approval verification functions from epoch manager #12417

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

stedfn
Copy link
Contributor

@stedfn stedfn commented Nov 8, 2024

No description provided.

@stedfn stedfn self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 31.08108% with 51 lines in your changes missing coverage. Please review.

Project coverage is 71.69%. Comparing base (fc801ad) to head (5283835).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
chain/chain/src/approval_verification.rs 39.62% 32 Missing ⚠️
chain/epoch-manager/src/adapter.rs 0.00% 15 Missing ⚠️
chain/chain/src/chain_update.rs 0.00% 3 Missing ⚠️
chain/chain/src/chain.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12417      +/-   ##
==========================================
+ Coverage   71.65%   71.69%   +0.04%     
==========================================
  Files         843      844       +1     
  Lines      170690   170709      +19     
  Branches   170690   170709      +19     
==========================================
+ Hits       122301   122397      +96     
+ Misses      43039    42953      -86     
- Partials     5350     5359       +9     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (+<0.01%) ⬆️
db-migration 0.16% <0.00%> (+<0.01%) ⬆️
genesis-check 1.27% <0.00%> (?)
integration-tests 39.35% <31.08%> (+0.08%) ⬆️
linux 70.98% <31.08%> (+0.32%) ⬆️
linux-nightly 71.27% <31.08%> (+0.02%) ⬆️
macos 50.66% <31.08%> (+0.01%) ⬆️
pytests 1.57% <0.00%> (+0.19%) ⬆️
sanity-checks 1.38% <0.00%> (+<0.01%) ⬆️
unittests 64.28% <31.08%> (-0.01%) ⬇️
upgradability 0.21% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant