Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resharding): delay split shard of flat store until resharding block is final #12415

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Trisfald
Copy link
Contributor

@Trisfald Trisfald commented Nov 8, 2024

Contents of this PR:

  • New features
    • Actual splitting of flat storage is delayed until the target resharding block becomes final
    • Scheduled resharding event can be overridden. This makes resharding work in many chain fork scenarios (not all of them though)
    • Added FlatStorageReshardingTaskSchedulingStatus to express the current state of scheduled tasks waiting for resharding block finality
  • Changes
    • Shard catchup doesn't wait anymore for resharding block finality. It is now a consequence of the fact that the shard split happens on a final block.
    • FlatStorageReshardingTaskStatus renamed into FlatStorageReshardingTaskResult for clarity
    • ReshardingActor now takes care of re-trying "postponed" tasks.

Part of #12174

@Trisfald Trisfald requested a review from a team as a code owner November 8, 2024 11:45
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 92.44186% with 26 lines in your changes missing coverage. Please review.

Project coverage is 71.75%. Comparing base (22259d0) to head (a62d1f1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
chain/chain/src/flat_storage_resharder.rs 93.18% 13 Missing and 8 partials ⚠️
chain/chain/src/resharding/resharding_actor.rs 86.11% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12415      +/-   ##
==========================================
+ Coverage   71.69%   71.75%   +0.06%     
==========================================
  Files         843      843              
  Lines      170777   170973     +196     
  Branches   170777   170973     +196     
==========================================
+ Hits       122440   122686     +246     
+ Misses      42974    42920      -54     
- Partials     5363     5367       +4     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (-0.01%) ⬇️
db-migration 0.16% <0.00%> (-0.01%) ⬇️
genesis-check 1.27% <0.00%> (-0.01%) ⬇️
integration-tests 39.29% <29.65%> (-0.07%) ⬇️
linux 71.06% <83.43%> (+0.07%) ⬆️
linux-nightly 71.33% <92.44%> (+0.05%) ⬆️
macos 50.77% <83.43%> (+0.12%) ⬆️
pytests 1.57% <0.00%> (-0.01%) ⬇️
sanity-checks 1.38% <0.00%> (-0.01%) ⬇️
unittests 64.35% <83.43%> (+0.07%) ⬆️
upgradability 0.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant