Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resharding) - use derive_shard_layout in the testloop test #12392

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

wacban
Copy link
Contributor

@wacban wacban commented Nov 5, 2024

Replace the custom create_new_shard_layout in the test with the proper derive_shard_layout.

@wacban wacban requested a review from a team as a code owner November 5, 2024 16:36
Copy link
Contributor

@staffik staffik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@wacban wacban enabled auto-merge November 5, 2024 16:51
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.63%. Comparing base (587c357) to head (fafcc98).
Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12392       +/-   ##
===========================================
+ Coverage    1.57%   71.63%   +70.05%     
===========================================
  Files         669      842      +173     
  Lines      119032   170700    +51668     
  Branches   119032   170700    +51668     
===========================================
+ Hits         1873   122275   +120402     
+ Misses     116954    43043    -73911     
- Partials      205     5382     +5177     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (+<0.01%) ⬆️
db-migration 0.16% <0.00%> (+<0.01%) ⬆️
genesis-check 1.27% <0.00%> (+<0.01%) ⬆️
integration-tests 39.21% <100.00%> (?)
linux 70.63% <100.00%> (+69.05%) ⬆️
linux-nightly 71.21% <100.00%> (?)
macos 50.61% <100.00%> (?)
pytests 1.57% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.38% <0.00%> (-0.01%) ⬇️
unittests 64.28% <100.00%> (?)
upgradability 0.21% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wacban wacban added this pull request to the merge queue Nov 7, 2024
Merged via the queue into master with commit 00153da Nov 7, 2024
30 checks passed
@wacban wacban deleted the waclaw-resharding branch November 7, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants