fix(state sync): handle StateResponse on state_parts_future_spawner #12205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12205 +/- ##
=======================================
Coverage 71.74% 71.75%
=======================================
Files 825 825
Lines 165697 165753 +56
Branches 165697 165753 +56
=======================================
+ Hits 118884 118928 +44
- Misses 41633 41640 +7
- Partials 5180 5185 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marcelo-gonzalez
approved these changes
Oct 11, 2024
saketh-are
requested review from
Longarithm and
VanBarbascu
and removed request for
Longarithm
marcelo-gonzalez
added a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Oct 11, 2024
…ear#12205) Before this PR, when a state part arrived via a network message from a peer, it was validated and stored by the client actor. As a result, the client actor could become slow to apply blocks causing the node to fall behind the chain. Instead, the state parts should be handled async on `state_parts_future_spawner` the same way they are when downloaded from external storage. --------- Co-authored-by: Marcelo Diop-Gonzalez <[email protected]>
marcelo-gonzalez
added a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Oct 11, 2024
…ear#12205) Before this PR, when a state part arrived via a network message from a peer, it was validated and stored by the client actor. As a result, the client actor could become slow to apply blocks causing the node to fall behind the chain. Instead, the state parts should be handled async on `state_parts_future_spawner` the same way they are when downloaded from external storage. --------- Co-authored-by: Marcelo Diop-Gonzalez <[email protected]>
Merged
marcelo-gonzalez
added a commit
that referenced
this pull request
Oct 11, 2024
bump version string and cherry pick #12205 --------- Co-authored-by: Saketh Are <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, when a state part arrived via a network message from a peer, it was validated and stored by the client actor. As a result, the client actor could become slow to apply blocks causing the node to fall behind the chain.
Instead, the state parts should be handled async on
state_parts_future_spawnerthe same way they are when downloaded from external storage.