Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PromiseIndex a newtype #1066

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Make PromiseIndex a newtype #1066

merged 2 commits into from
Aug 17, 2023

Conversation

uint
Copy link
Contributor

@uint uint commented Aug 10, 2023 •
edited
Loading

Closes #945

This is breaking and should only be released with a major version bump (5.0.0)

frol
frol approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Given that we already have quite a couple of breaking changes, I am going ahead and merging it into master. I will cherry-pick some of the PRs to make 4.x release if necessary.

@frol frol merged commit f5cce80 into master Aug 17, 2023
13 checks passed
@frol frol deleted the 945-promise-index-newtype branch August 17, 2023 21:28
@frol frol mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@agostbiro agostbiro Awaiting requested review from agostbiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make PromiseIndex a newtype to avoid misuse
2 participants
@uint @frol