Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have #[handle_result] support Result types regardless of how they're referred to #1057

Closed
wants to merge 5 commits into from
Closed

Have #[handle_result] support Result types regardless of how they're referred to #1057

wants to merge 5 commits into from

Conversation

uint
Copy link
Contributor

@uint uint commented Jul 20, 2023

Closes #852

@uint uint force-pushed the 852-handle_result-result-detection branch from abbdd8f to da2676b Compare July 20, 2023 16:59
@uint uint marked this pull request as ready for review July 20, 2023 16:59
@uint uint requested review from frol and agostbiro as code owners July 20, 2023 16:59
@frol frol mentioned this pull request Jul 31, 2023
Open
@uint uint mentioned this pull request Aug 18, 2023
Open
@uint uint requested a review from agostbiro August 18, 2023 18:48
@iho iho mentioned this pull request Oct 20, 2023
Merged
@frol
Copy link
Collaborator

frol commented Oct 22, 2023

This PR was superseded by #1099

@frol frol closed this Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell left review comments

@frol frol Awaiting requested review from frol frol is a code owner

@agostbiro agostbiro Awaiting requested review from agostbiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[handle_result] should not rely on Result being referred to using specific tokens
4 participants
@uint @frol @agostbiro @austinabell