Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Please just squash merge this and the squash merge will satisfy the criteria.
pnpm changeset
to create achangeset
JSON document appropriate for this change.Motivation
I have been getting annoyed by this package resolution warning:
This is caused by a very tiny piece of middleware (bs58) that is not very professionally managed or updated and prevents us from keeping the primary dependency updated.
To solve this, we copy the 3 lines of code coming from that middle ware into an identical file directly into this project and migrate our dependency to
base-x
.Alternative solution would be to fix the dependency's build issue and re-depend on it.
Test Plan
Added unit tests transcribed from the former dependency.
https://github.com/cryptocoinjs/bs58/blob/master/test/index.js
Related issues/PRs