Multi contract keystore #1369
Closed
Multi contract keystore #1369
+260
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5148b67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
andy-haynes
requested changes
Aug 5, 2024
| constructor(localStorage: any = window.localStorage, prefix = LOCAL_STORAGE_KEY_PREFIX) { | ||
| super(); | ||
| this.localStorage = localStorage; | ||
| this.prefix = prefix; |
There was a problem hiding this comment.
Can we please make this this.prefix = prefix || LOCAL_STORAGE_PREFIX;?
In the current implementation, an empty string prefix means clear() would delete all localstorage entries.
There was a problem hiding this comment.
Let's merge the original PR into a feature branch.
andy-haynes
changed the base branch from
master
to
feat/multi-contract-keystore-rebased
andy-haynes
changed the base branch from
feat/multi-contract-keystore-rebased
to
master
andy-haynes
changed the base branch from
master
to
feat/multi-contract-keystore-rebased
|
Moved to #1370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
pnpm changesetto create achangesetJSON document appropriate for this change.Motivation
Test Plan
Added unit tests.
Related issues/PRs
#1163