Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how timeout error is handled #1295

Closed
wants to merge 4 commits into from
Closed

Update how timeout error is handled #1295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90da0db
fix: update how timeout error is handled
gtsonevv Feb 15, 2024
883c300
fix: linter
gtsonevv Feb 15, 2024
bd19a27
fix: remove console.log
gtsonevv Feb 15, 2024
1a50916
Merge branch 'master' into update-rpc-error-handling
gtsonevv May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chilly-plants-admire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@near-js/providers": patch
---

Update how timeout error is handled.
5 changes: 1 addition & 4 deletions packages/providers/src/json-rpc-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,10 +397,7 @@ export class JsonRpcProvider extends Provider {
throw parseRpcError(response.error.data);
} else {
const errorMessage = `[${response.error.code}] ${response.error.message}: ${response.error.data}`;
// NOTE: All this hackery is happening because structured errors not implemented
// TODO: Fix when https://github.com/nearprotocol/nearcore/issues/1839 gets resolved
if (response.error.data === 'Timeout' || errorMessage.includes('Timeout error')
|| errorMessage.includes('query has timed out')) {
if (response.error.data === 'Timeout') {
throw new TypedError(errorMessage, 'TimeoutError');
}

Expand Down
Loading