feat: implement signing #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Feature Environment (dev-380)Terraform Initialization ⚙️
|
itegulov
force-pushed
the
daniyar/multichain-signature
branch
from
f6d3989
to
0423757
Compare
|
@itegulov do yo want to merge it with the failing test and then fix it? |
Merged
volovyks
previously approved these changes
Nov 22, 2023
| @@ -8,23 +8,22 @@ publish = false | |||
| aes-gcm = "0.10" | |||
| anyhow = { version = "1.0", features = ["backtrace"] } | |||
| async-process = "1" | |||
| aws-config = "0.54.0" | |||
There was a problem hiding this comment.
Why AWS? IS it because Lake Framework is intended to work with it?
There was a problem hiding this comment.
Yes, needed for Lake Framework configuration
| let payload: [u8; 32] = rand::thread_rng().gen(); | ||
| let outcome = ctx | ||
| .rpc_client | ||
| .send_tx( |
There was a problem hiding this comment.
Since the protocol feature is yet to be implemented, what is our plan here (for this PR and first testnet release)?
There was a problem hiding this comment.
We are just making a separate unrelated transaction with the response
itegulov
force-pushed
the
daniyar/multichain-signature
branch
from
98eb562
to
de5d7c0
Compare
volovyks
approved these changes
Nov 23, 2023
Terraform Feature Environment Destroy (dev-380)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies that this code is pretty hairy and that PR is touching a million different things, but I had to fix many little bugs to make this actually work.
I tried to serialize the resulting signature into something more conventional for NEAR's ecosystem, but spent 3 hours going through different tags, SEC1 variations and compression without writing anything that works. So I am leaving that for a follow-up PR.