presignature bad parameters error check

chain-signatures/node/src/protocol/presignature.rs

@@ -167,6 +167,8 @@ pub enum GenerationError {
     PresignatureIsMissing(PresignatureId),
     #[error("presignature {0} is in garbage collection")]
     PresignatureIsGarbageCollected(TripleId),
+    #[error("presignature bad parameters")]
+    PresignatureBadParameters,
 }
 
 /// Abstracts how triples are generated by providing a way to request a new triple that will be
@@ -511,17 +513,10 @@ impl PresignatureManager {
         private_share: &SecretKeyShare,
         cfg: &ProtocolConfig,
     ) -> Result<&mut PresignatureProtocol, GenerationError> {
-        // TODO: why do we need to pass the id here? Double check.
-        let expected_id = hash_as_id(triple0, triple1);
-        if id != expected_id {
-            tracing::warn!(
-                id,
-                expected_id,
-                "presignature id does not match the hash of the triples"
-            );
-            return Err(GenerationError::PresignatureIsMissing(id));
-        }
-        if self.contains(&id).await {
+        if id != hash_as_id(triple0, triple1) {
+            tracing::error!(id, "presignature id does not match the expected hash");
+            return Err(GenerationError::PresignatureBadParameters);
+        } else if self.contains(&id).await {
             tracing::debug!(id, "presignature already generated");
             Err(GenerationError::AlreadyGenerated)
         } else if self.gc.contains_key(&id) {

chain-signatures/node/src/storage/presignature_storage.rs

@@ -46,8 +46,6 @@ impl RedisPresignatureStorage {
     }
 }
 
-// Note: it is possible to use a Lua script to make all operations atomic
-// TODO: add logs and better error handling
 #[async_trait]
 impl PresignatureStorage for RedisPresignatureStorage {
     fn insert(&mut self, presignature: Presignature) -> PresigResult<()> {