feat: return JSON-based ABI generation #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miraclx
reviewed
Oct 19, 2022
Comment on lines
+54
to
+63
| Args: IntoIterator<Item = Arg>, | ||
| Arg: AsRef<OsStr>, | ||
| TPath: AsRef<Path>, | ||
| Env: IntoIterator<Item = (EnvKey, EnvVal)>, | ||
| EnvKey: AsRef<OsStr>, | ||
| EnvVal: AsRef<OsStr>, | ||
| StdoutFn: FnOnce(ChildStdout) -> Result<StdoutResult, std::io::Error> + Send + 'static, | ||
| StdoutResult: Send + 'static, | ||
| StderrFn: FnOnce(ChildStderr) -> Result<StderrResult, std::io::Error> + Send + 'static, | ||
| StderrResult: Send + 'static, |
There was a problem hiding this comment.
I've seen some crates use cargo as a direct dependency, apparently it has a public facing API separate from the CLI, just never used it directly.
|
|
||
| fn main() -> Result<(), std::io::Error> { | ||
| let abi_entries: Vec<near_sdk::__private::ChunkedAbiEntry> = vec![#(#near_abi_function_invocations),*]; | ||
| let contents = serde_json::to_string_pretty(&abi_entries)?; |
There was a problem hiding this comment.
We can actually move this bit to the SDK, simplifying things. See alt: #74
There was a problem hiding this comment.
Not really, it may look similar but there is an important difference that I have touched upon here: #74 (review)
There was a problem hiding this comment.
Yeah, I was thinking a Rust String might be safe, but since we don't have that guarantee, it's just best to switch to the C ABI.
Co-authored-by: Miraculous Owonubi <[email protected]>
|
Closed in favor of #74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
Basically reverts #35 with some refactoring and better error messages
Also, this whole
invoke_cargoshebang is getting out of hand. I am surprised there is no crate that encapsulates this tbh